fix: allow Any type for logging message parameter#2367
Open
mac-agent wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: allow Any type for logging message parameter#2367mac-agent wants to merge 1 commit intomodelcontextprotocol:mainfrom
mac-agent wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Change the type annotation of the message parameter in Context.log(),
Context.debug(), Context.info(), Context.warning(), and Context.error()
from str to Any.
The MCP spec defines the log data field as:
data: unknown - "Any JSON serializable type is allowed here"
This allows MCP servers to send rich structured notifications:
ctx.info({"event": "progress", "percent": 50})
The parameter name is kept as message for backward compatibility.
Fixes modelcontextprotocol#397
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change the type annotation of the
messageparameter inContext.log(),Context.debug(),Context.info(),Context.warning(), andContext.error()fromstrtoAny.Problem
The MCP spec defines the log data field as:
But the Python SDK types the message as
str, preventing rich structured logging like:Solution
message: strtomessage: Anyin all 5 logging methodsmessagefor backward compatibilityChanges
src/mcp/server/mcpserver/context.py: Type annotation changes onlyFixes #397