fix(auth): add Accept header to token and refresh requests#2699
Open
william-xue wants to merge 1 commit into
Open
fix(auth): add Accept header to token and refresh requests#2699william-xue wants to merge 1 commit into
william-xue wants to merge 1 commit into
Conversation
OAuthClientProvider._build_token_request and _refresh_token did not include an Accept header, so servers that default to form-encoded responses (e.g. GitHub's OAuth token endpoint) would not return JSON. This caused token exchange to fail with a parse error. Added Accept: application/json to both token exchange and refresh requests so servers know to respond with JSON.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OAuth token and refresh requests do not include an
Accept: application/jsonheader. Servers that default to form-encoded responses (e.g. GitHub's OAuth token endpoint) will not return JSON, causinghandle_token_response_scopesto fail with a parse error.This adds
Accept: application/jsonto both_build_token_requestand_refresh_tokenso servers know to respond with JSON.Fixes #1523
Test plan
Acceptheader assertions to existingtest_token_exchange_request_authorization_codeandtest_refresh_token_requesttestsuv run --frozen pytest tests/client/test_auth.pyRisk
Minimal — only adds a standard HTTP header to outgoing requests. No behavioral change for servers already returning JSON.