build: enable backtrace when V8 is built for PPC and S390x

targos · richardlau · commit 020ba1a2b8b3 · 2020-10-05T10:56:22.000-04:00
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/common.gypi b/common.gypi
@@ -96,6 +96,9 @@
       ['OS=="mac"', {
         'clang%': 1,
       }],
+      ['target_arch in "ppc64 s390x"', {
+        'v8_enable_backtrace': 1,
+      }],
     ],
   },
 
diff --git a/tools/make-v8.sh b/tools/make-v8.sh
@@ -28,7 +28,7 @@ if [[ "$ARCH" == "s390x" ]] || [[ "$ARCH" == "ppc64le" ]]; then
   g++ --version
   gcc --version
   export PKG_CONFIG_PATH=$BUILD_TOOLS/pkg-config
-  gn gen -v out.gn/$BUILD_ARCH_TYPE --args="is_component_build=false is_debug=false use_goma=false goma_dir=\"None\" use_custom_libcxx=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\""
+  gn gen -v out.gn/$BUILD_ARCH_TYPE --args="is_component_build=false is_debug=false use_goma=false goma_dir=\"None\" use_custom_libcxx=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true"
   ninja -v -C out.gn/$BUILD_ARCH_TYPE d8 cctest inspector-test
 else
   PATH=~/_depot_tools:$PATH tools/dev/v8gen.py $BUILD_ARCH_TYPE --no-goma $V8_BUILD_OPTIONS
