pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/nodejs/node/commit/c7931e44381eb27668e70834718bc5daf22a4866

mer-b69241e157469407.css" /> deps: backport ICU-20558 to fix Intl crasher · nodejs/node@c7931e4 · GitHub
Skip to content

Commit c7931e4

Browse files
srl295MylesBorins
authored andcommitted
deps: backport ICU-20558 to fix Intl crasher
- Floating patch for ICU 63.x and 64.x - fixing crash in Intl when ICU data not found. - Regression test from refack included. Background: - ICU-13778 (landed in ICU 63.1) fixed a bug but added a regression. - a recent v8 land in Node v12 (which one?) exposes this bug to cause a crash when ICU data is not found. ICU Bug: https://unicode-org.atlassian.net/browse/ICU-20558 Backport of: unicode-org/icu#632 Fixes: #27379 Co-authored-by: Refael Ackermann <refack@gmail.com> PR-URL: #27415 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
1 parent 0fd4b35 commit c7931e4

File tree

3 files changed

+5541
-0
lines changed

3 files changed

+5541
-0
lines changed

test/parallel/test-intl.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
'use strict';
2323
const common = require('../common');
2424
const assert = require('assert');
25+
const { execFile } = require('child_process');
2526

2627
// does node think that i18n was enabled?
2728
let enablei18n = process.config.variables.v8_enable_i18n_support;
@@ -125,4 +126,14 @@ if (!common.hasIntl) {
125126
assert.strictEqual(coll.compare('Bluebird', 'bluebird'), 0);
126127
// ffi ligature (contraction)
127128
assert.strictEqual(coll.compare('\ufb03', 'ffi'), 0);
129+
130+
{
131+
// Regression test for https://github.com/nodejs/node/issues/27379
132+
const env = { ...process.env, LC_ALL: 'ja' };
133+
execFile(
134+
process.execPath, ['-p', 'new Date().toLocaleString()'],
135+
{ env },
136+
common.mustCall((e) => assert.ifError(e))
137+
);
138+
}
128139
}

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.





Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy