lib: migrate from process.binding to internalBinding

madeinjam · MylesBorins · commit cb597f231a7c · 2018-11-29T11:38:30.000-05:00
We are migrating towards using internalBinding(\'options\').getOptions() instead of process.binding(\'config\') to access the value of the --experimental-vm-modules command line option. PR-URL: #23586 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
diff --git a/lib/vm.js b/lib/vm.js
@@ -402,7 +402,7 @@ module.exports = {
   compileFunction,
 };
 
-if (process.binding('config').experimentalVMModules) {
+if (internalBinding('options').getOptions('--experimental-vm-modules')) {
   const { SourceTextModule } = require('internal/vm/source_text_module');
   module.exports.SourceTextModule = SourceTextModule;
 }
diff --git a/test/sequential/test-inspector-has-inspector-false.js b/test/sequential/test-inspector-has-inspector-false.js
@@ -0,0 +1,15 @@
+// Flags: --expose-internals
+'use strict';
+
+const common = require('../common');
+
+// This is to ensure that the sendInspectorCommand function calls the error
+// function if its called with the v8_enable_inspector is disabled
+
+process.config.variables.v8_enable_inspector = 0;
+const inspector = require('internal/util/inspector');
+
+inspector.sendInspectorCommand(
+  common.mustNotCall('Inspector callback should not be called'),
+  common.mustCall(1),
+);

Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,7 @@ module.exports = {`
`402`	`402`	`compileFunction,`
`403`	`403`	`};`
`404`	`404`
`405`		`-if (process.binding('config').experimentalVMModules) {`
	`405`	`+if (internalBinding('options').getOptions('--experimental-vm-modules')) {`
`406`	`406`	`const { SourceTextModule } = require('internal/vm/source_text_module');`
`407`	`407`	`module.exports.SourceTextModule = SourceTextModule;`
`408`	`408`	`}`