pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/nodejs/node/pull/62660

assets/global-c9ae636e7affabfe.css" /> test: generate localstorage-file in a temp dir by legendecas · Pull Request #62660 · nodejs/node · GitHub
Skip to content

test: generate localstorage-file in a temp dir#62660

Open
legendecas wants to merge 2 commits intonodejs:mainfrom
legendecas:test-inspector-dom-storage
Open

test: generate localstorage-file in a temp dir#62660
legendecas wants to merge 2 commits intonodejs:mainfrom
legendecas:test-inspector-dom-storage

Conversation

@legendecas
Copy link
Copy Markdown
Member

@legendecas legendecas commented Apr 9, 2026

Fixes #62646

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 9, 2026
@aduh95 aduh95 added fast-track PRs that do not need to wait for 72 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Fast-track has been requested by @aduh95. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 9, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 9, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72596/

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.81%. Comparing base (41afe9b) to head (2d7d79f).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62660      +/-   ##
==========================================
+ Coverage   89.79%   89.81%   +0.02%     
==========================================
  Files         699      699              
  Lines      216163   216235      +72     
  Branches    41327    41333       +6     
==========================================
+ Hits       194110   194218     +108     
+ Misses      14173    14131      -42     
- Partials     7880     7886       +6

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardlau
Copy link
Copy Markdown
Member

richardlau commented Apr 9, 2026

The test fails when the test runner is run with --worker: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/46721/

23:44:15 not ok 2722 parallel/test-inspector-dom-storage
23:44:15   ---
23:44:15   duration_ms: 266.83200
23:44:15   severity: fail
23:44:15   exitcode: 1
23:44:15   stack: |-
23:44:15     Debugger listening on ws://127.0.0.1:41107/02f516b4-82f3-4a62-926f-c75e2b6e497b
23:44:15     For help, see: https://nodejs.org/en/docs/inspector
23:44:15     
23:44:15     node:internal/event_target:1118
23:44:15       process.nextTick(() => { throw err; });
23:44:15                                ^
23:44:15     TypeError [ERR_WORKER_UNSUPPORTED_OPERATION]: process.chdir() is not supported in workers
23:44:15         at process.unavailableInWorker [as chdir] (node:internal/process/worker_thread_only:14:11)
23:44:15         at Object.<anonymous> (/home/iojs/build/workspace/node/test/parallel/test-inspector-dom-storage.js:10:9)
23:44:15         at Module._compile (node:internal/modules/cjs/loader:1829:14)
23:44:15         at Object..js (node:internal/modules/cjs/loader:1969:10)
23:44:15         at Module.load (node:internal/modules/cjs/loader:1552:32)
23:44:15         at Module._load (node:internal/modules/cjs/loader:1354:12)
23:44:15         at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
23:44:15         at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:154:5)
23:44:15         at MessagePort.<anonymous> (node:internal/main/worker_thread:223:26)
23:44:15         at [nodejs.internal.kHybridDispatch] (node:internal/event_target:843:20) {
23:44:15       code: 'ERR_WORKER_UNSUPPORTED_OPERATION'
23:44:15     }
23:44:15     
23:44:15     Node.js v26.0.0-pre
23:44:15   ...

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 10, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72605/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

@avivkeller avivkeller avivkeller approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parallel/test-inspector-dom-storage writes to current working directory

6 participants

@legendecas @nodejs-github-bot @richardlau @cjihrig @aduh95 @avivkeller
pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.




Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy