feat: drop support for php < 8.1, drop support for symfony < 5.4 (WIP)#243
Open
Chris53897 wants to merge 5 commits intophp-http:2.xfrom
Open
feat: drop support for php < 8.1, drop support for symfony < 5.4 (WIP)#243Chris53897 wants to merge 5 commits intophp-http:2.xfrom
Chris53897 wants to merge 5 commits intophp-http:2.xfrom
Conversation
dbu
reviewed
Jan 23, 2024
Contributor
dbu
left a comment
dbu
left a comment
There was a problem hiding this comment.
thanks a lot!
the failing tests (apart from the stream_for issue) are probably also about missing mocking that is now detected because of strict typing of 3rd party libraries. do you look into those?
drop support for symfony < 5.4,
drop support for symfony < 5.4,
Chris53897
force-pushed
the
feature/php-81
branch
from
4ca858f to
9d01ac4
Compare
dbu
reviewed
Jan 23, 2024
drop support for symfony < 5.4,
drop support for symfony < 5.4,
|
ping, could this be revived? It would be great to remove those unneeded dependencies for PHP 8. |
Contributor
Author
|
I resolved the conflicts. But there are errors. Maybe i have time at end of march to have a deeper look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#242
Just a quick view and open for disussion what to do next.
Needs rebasing after the other 2 PRs are merged.
Checklist
To Do