fix: Typehint the Stream class and fix deprecated interface HttpClient#70
Open
tarekdj wants to merge 2 commits intophp-http:2.xfrom
Open
fix: Typehint the Stream class and fix deprecated interface HttpClient#70tarekdj wants to merge 2 commits intophp-http:2.xfrom
tarekdj wants to merge 2 commits intophp-http:2.xfrom
Conversation
Contributor
|
we could switch this client to be a PSR-18 client. but that would mean somebody would need to commit to maintain this client. there are a bunch of http clients around: symfony, guzzle, buzz, the php-http/curl-client and some others. is there value in keeping the socket client alive? |
Contributor
|
if we decide to keep this maintained, we should adjust the socket-client.rst page in the documentation, reverting php-http/documentation#310 (comment) and maybe add more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Why?
Fix the compatibility of Stream class with the StreamInterface
Checklist
To Do