Fix: line 57 for undefined $q, also changed wording for consistency.#4521
Merged
GaryAllan merged 1 commit intophpipam:developfrom Mar 17, 2026
Merged
Fix: line 57 for undefined $q, also changed wording for consistency.#4521GaryAllan merged 1 commit intophpipam:developfrom
GaryAllan merged 1 commit intophpipam:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning: [07-Nov-2025 17:44:47 UTC] PHP Warning: Undefined variable $q in /var/www/phpipam/app/subnets/scan/subnet-scan-execute-snmp-route-all.php on line 57
Summary
foreachloop, no. For writing clear, maintainable code, yes, absolutely."get_vlan_table"to"get_routing_table"to accurately reflect the data being stored.foreach ($device as $query_result)iterates over the values of the$devicearray, regardless of what the keys are named. (So no change in code)