Remove useless prefix in admin bind username#4579
Open
caromeo wants to merge 2 commits intophpipam:masterfrom
Open
Remove useless prefix in admin bind username#4579caromeo wants to merge 2 commits intophpipam:masterfrom
caromeo wants to merge 2 commits intophpipam:masterfrom
Conversation
When using openLDAP the "uid" prefix is already set inside "$username.$this->accountSuffix" variable so it is unnecessary to add it twice. This fix solves the problem of the research when trying to reach the following form: Administration -> Users -> Create User -> Enter username. Applying this small change will allow to search the user on openLDAP using the correct admin bind user.
When Admin searches an LDAP user to be added it may happen, with some not standard server configurations, that the proposed username in the following form (after the search) will not be populated because it is looking for the 'samaccountname' variable which is not always clearly declared in the $userinfo. It should be better directly to give to the next form the username used in the previous research, which is stored in $esc_dname.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using openLDAP the "uid" prefix is already set inside "$username.$this->accountSuffix" variable so it is unnecessary to add it twice. This fix solves the problem of the research when trying to reach the following form: Administration -> Users -> Create User -> Enter username. Applying this small change will allow to search the user on openLDAP using the correct admin bind user.
When Admin searches an LDAP user to be added it may happen, with some not standard server configurations, that the proposed username in the following form (after the search) will not be populated because it is looking for the 'samaccountname' variable which is not always clearly declared in the $userinfo. It should be better directly to give to the next form the username used in the previous research, which is stored in $esc_dname.