Fix tick marker mirroring (matplotlib conversion)#5310
Open
robertoffmoura wants to merge 2 commits intoplotly:mainfrom
Open
Fix tick marker mirroring (matplotlib conversion)#5310robertoffmoura wants to merge 2 commits intoplotly:mainfrom
robertoffmoura wants to merge 2 commits intoplotly:mainfrom
Conversation
robertoffmoura
force-pushed
the
rm/fix-tick-marker-mirroring
branch
2 times, most recently
from
3fafa67 to
daf0327
Compare
gvwilson
added
P1
robertoffmoura
force-pushed
the
rm/fix-tick-marker-mirroring
branch
from
860b8b0 to
001ff53
Compare
Contributor
|
Hi @robertoffmoura, thank you for the fix! Same question here, could you provide some side-by-side comparisons to show the difference this PR introduces and why this is the correct behavior? I'm not very familiar with axis mirroring in matplotlib (or Plotly for that matter) so just trying to sanity check that these changes make sense. I took a quick look at the images of the plots in the tests you added, and the only one where I see a difference between your branch and |
robertoffmoura
force-pushed
the
rm/fix-tick-marker-mirroring
branch
from
001ff53 to
60cd4f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This fixes the issue where a matplotlib figure with only bottom and left tick markers would be converted to a plotly figure with markers on all sides.
Code PR
plotly.graph_objects, my modifications concern the code generator and not the generated files.