Add relpath test for Windows error coverage#2571
Open
m-rsha wants to merge 2 commits intopre-commit:mainfrom
Open
Add relpath test for Windows error coverage#2571m-rsha wants to merge 2 commits intopre-commit:mainfrom
relpath test for Windows error coverage#2571m-rsha wants to merge 2 commits intopre-commit:mainfrom
Conversation
m-rsha
force-pushed
the
test-relpath
branch
2 times, most recently
from
8ad9492 to
7454d6c
Compare
Member
|
@m-rsha I think this needs an assertion showing that it preserves the value -- and maybe some more realistic inputs / outputs to demonstrate it's trying to handle windows paths on different drives? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2531 , beep boop.