#19688: add back and deprecate the internal HTMLParser.unescape() method.

ezio-melotti · ezio-melotti · commit f6de9eb2bb3c · 2013-11-22T05:49:29.000+02:00
diff --git a/Lib/html/parser.py b/Lib/html/parser.py
@@ -513,3 +513,10 @@ def handle_pi(self, data):
     def unknown_decl(self, data):
         if self.strict:
             self.error("unknown declaration: %r" % (data,))
+
+    # Internal -- helper to remove special character quoting
+    def unescape(self, s):
+        warnings.warn('The unescape method is deprecated and will be removed '
+                      'in 3.5, use html.unescape() instead.',
+                      DeprecationWarning, stacklevel=2)
+        return unescape(s)
diff --git a/Lib/test/test_htmlparser.py b/Lib/test/test_htmlparser.py
@@ -569,6 +569,13 @@ def test_EOF_in_charref(self):
         for html, expected in data:
             self._run_check(html, expected)
 
+    def test_unescape_method(self):
+        from html import unescape
+        p = self.get_collector()
+        with self.assertWarns(DeprecationWarning):
+            s = '&quot;&#34;&#x22;&quot&#34&#x22&#bad;'
+            self.assertEqual(p.unescape(s), unescape(s))
+
     def test_broken_comments(self):
         html = ('<! not really a comment >'
                 '<! not a comment either -->'
