gh-113842: Add missing error check for PyIter_Next() in Python/symtable.c (GH-113843)

WolframAlph · web-flow · commit fda901a1ff94 · 2024-01-09T12:43:58.000+02:00
diff --git a/Python/symtable.c b/Python/symtable.c
@@ -977,6 +977,12 @@ update_symbols(PyObject *symbols, PyObject *scopes,
         }
         Py_DECREF(name);
     }
+
+    /* Check if loop ended because of exception in PyIter_Next */
+    if (PyErr_Occurred()) {
+        goto error;
+    }
+
     Py_DECREF(itr);
     Py_DECREF(v_free);
     return 1;

Original file line number	Diff line number	Diff line change
`@@ -977,6 +977,12 @@ update_symbols(PyObject symbols, PyObject scopes,`
`977`	`977`	`}`
`978`	`978`	`Py_DECREF(name);`
`979`	`979`	`}`
	`980`	`+`
	`981`	`+ /* Check if loop ended because of exception in PyIter_Next */`
	`982`	`+ if (PyErr_Occurred()) {`
	`983`	`+ goto error;`
	`984`	`+ }`
	`985`	`+`
`980`	`986`	`Py_DECREF(itr);`
`981`	`987`	`Py_DECREF(v_free);`
`982`	`988`	`return 1;`