Declutterfier! Saves Data!

--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/python/cpython/pull/112619.patch

_[0]), A) + self.assertEqual(field_a1.__metadata__[0], A("X")) + self.assertEqual(type(field_a2.__metadata__[0]), B) + self.assertEqual(field_a2.__metadata__[0], B("X")) + + field_b1 = Annotated[str, A("Y")] + field_b2 = Annotated[str, B("Y")] + + self.assertEqual(type(field_b1.__metadata__[0]), A) + self.assertEqual(field_b1.__metadata__[0], A("Y")) + self.assertEqual(type(field_b2.__metadata__[0]), B) + self.assertEqual(field_b2.__metadata__[0], B("Y")) + + field_c1 = Annotated[int, 1] + field_c2 = Annotated[int, 1.0] + field_c3 = Annotated[int, True] + + self.assertEqual(type(field_c1.__metadata__[0]), int) + self.assertEqual(type(field_c2.__metadata__[0]), float) + self.assertEqual(type(field_c3.__metadata__[0]), bool) class TypeAliasTests(BaseTestCase): From 13eb1926f7bcaa9fa843e31c8af8983746d22a04 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Sat, 2 Dec 2023 17:12:33 +0300 Subject: [PATCH 6/9] Address review --- Lib/test/test_typing.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py index 3221c6216942f9..27a24b60ffbe3a 100644 --- a/Lib/test/test_typing.py +++ b/Lib/test/test_typing.py @@ -8682,26 +8682,26 @@ class B(str): ... field_a1 = Annotated[str, A("X")] field_a2 = Annotated[str, B("X")] - self.assertEqual(type(field_a1.__metadata__[0]), A) + self.assertIs(type(field_a1.__metadata__[0]), A) self.assertEqual(field_a1.__metadata__[0], A("X")) - self.assertEqual(type(field_a2.__metadata__[0]), B) + self.assertIs(type(field_a2.__metadata__[0]), B) self.assertEqual(field_a2.__metadata__[0], B("X")) field_b1 = Annotated[str, A("Y")] field_b2 = Annotated[str, B("Y")] - self.assertEqual(type(field_b1.__metadata__[0]), A) + self.assertIs(type(field_b1.__metadata__[0]), A) self.assertEqual(field_b1.__metadata__[0], A("Y")) - self.assertEqual(type(field_b2.__metadata__[0]), B) + self.assertIs(type(field_b2.__metadata__[0]), B) self.assertEqual(field_b2.__metadata__[0], B("Y")) field_c1 = Annotated[int, 1] field_c2 = Annotated[int, 1.0] field_c3 = Annotated[int, True] - self.assertEqual(type(field_c1.__metadata__[0]), int) - self.assertEqual(type(field_c2.__metadata__[0]), float) - self.assertEqual(type(field_c3.__metadata__[0]), bool) + self.assertIs(type(field_c1.__metadata__[0]), int) + self.assertIs(type(field_c2.__metadata__[0]), float) + self.assertIs(type(field_c3.__metadata__[0]), bool) class TypeAliasTests(BaseTestCase): From 0a842a0307003edd54821b13f2fb5109593470ab Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Sat, 2 Dec 2023 17:23:37 +0300 Subject: [PATCH 7/9] Update 2023-12-02-12-55-17.gh-issue-112618.7_FT8-.rst --- .../next/Library/2023-12-02-12-55-17.gh-issue-112618.7_FT8-.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/Library/2023-12-02-12-55-17.gh-issue-112618.7_FT8-.rst b/Misc/NEWS.d/next/Library/2023-12-02-12-55-17.gh-issue-112618.7_FT8-.rst index 89b4c0b49d3db5..c732de15609c96 100644 --- a/Misc/NEWS.d/next/Library/2023-12-02-12-55-17.gh-issue-112618.7_FT8-.rst +++ b/Misc/NEWS.d/next/Library/2023-12-02-12-55-17.gh-issue-112618.7_FT8-.rst @@ -1,2 +1,2 @@ Fix a caching bug relating to :data:`typing.Annotated`. -``Annotated[str, True]`` is no longer equal to ``Annotated[str, 1]``. +``Annotated[str, True]`` is no longer identical to ``Annotated[str, 1]``. From b83154b5db35361fd898bb63d5635103611e3ce2 Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Sat, 2 Dec 2023 17:48:13 +0300 Subject: [PATCH 8/9] Apply suggestions from code review Co-authored-by: Alex Waygood --- Lib/test/test_typing.py | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py index 27a24b60ffbe3a..0305495235ac6a 100644 --- a/Lib/test/test_typing.py +++ b/Lib/test/test_typing.py @@ -8681,19 +8681,25 @@ class B(str): ... field_a1 = Annotated[str, A("X")] field_a2 = Annotated[str, B("X")] + a1_metadata = field_a1.__metadata__[0] + a2_metadata = field_a2.__metadata__[0] - self.assertIs(type(field_a1.__metadata__[0]), A) - self.assertEqual(field_a1.__metadata__[0], A("X")) - self.assertIs(type(field_a2.__metadata__[0]), B) - self.assertEqual(field_a2.__metadata__[0], B("X")) + self.assertIs(type(a1_metadata), A) + self.assertEqual(a1_metadata, A("X")) + self.assertIs(type(a2_metadata, B) + self.assertEqual(a2_metadata, B("X")) + self.assertIsNot(type(a1_metadata), type(a2_metadata)) field_b1 = Annotated[str, A("Y")] field_b2 = Annotated[str, B("Y")] - - self.assertIs(type(field_b1.__metadata__[0]), A) - self.assertEqual(field_b1.__metadata__[0], A("Y")) - self.assertIs(type(field_b2.__metadata__[0]), B) - self.assertEqual(field_b2.__metadata__[0], B("Y")) + b1_metadata = field_b1.__metadata__[0] + b2_metadata = field_b2.__metadata__[0] + + self.assertIs(type(b1_metadata), A) + self.assertEqual(b1_metadata, A("Y")) + self.assertIs(type(b2_metadata), B) + self.assertEqual(b2_metadata, B("Y")) + self.assertIsNot(type(b1_metadata), type(b2_metadata)) field_c1 = Annotated[int, 1] field_c2 = Annotated[int, 1.0] From 5025f1c406374090f273db344e6ff784466690a8 Mon Sep 17 00:00:00 2001 From: AlexWaygood Date: Sat, 2 Dec 2023 14:51:19 +0000 Subject: [PATCH 9/9] fix syntaxerror --- Lib/test/test_typing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py index 0305495235ac6a..3572df7737f652 100644 --- a/Lib/test/test_typing.py +++ b/Lib/test/test_typing.py @@ -8686,7 +8686,7 @@ class B(str): ... self.assertIs(type(a1_metadata), A) self.assertEqual(a1_metadata, A("X")) - self.assertIs(type(a2_metadata, B) + self.assertIs(type(a2_metadata), B) self.assertEqual(a2_metadata, B("X")) self.assertIsNot(type(a1_metadata), type(a2_metadata)) pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies: