gh-134584 : Optimize and eliminate redundant ref-counting for MAKE_FUNCTION in the JIT#144963
Open
Sacul0457 wants to merge 12 commits intopython:mainfrom
Open
gh-134584 : Optimize and eliminate redundant ref-counting for MAKE_FUNCTION in the JIT#144963Sacul0457 wants to merge 12 commits intopython:mainfrom
MAKE_FUNCTION in the JIT#144963Sacul0457 wants to merge 12 commits intopython:mainfrom
Conversation
Sacul0457
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
Member
|
MAKE_FUNCTION might not be a common opcode/show up in the JIT. So I doubt we will see speedups from this one, it's still good to add it to the optimizer though so thanks. |
35 tasks
markshannon
approved these changes
Mar 12, 2026
Member
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Looks good.
@Sacul0457 can you update this branch so it can be merged?
Contributor
Author
|
I'm can't seem to find the error logs for the CI failure, so I'm not sure what's the cause of the failure and whether it's related to this PR or not |
Member
|
Sometimes the sanitizer CI is a little flaky, so I've triggered a re-run. |
Contributor
Author
|
Seems to pass now, thx! |
Contributor
|
There are new merge conflicts. |
Contributor
Author
|
fixed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @Fidget-Spinner for guiding!
Adds
_MAKE_FUNCTIONtooptimizer_bytecodes.cand eliminates redundant ref-counting forMAKE_FUNCTION.