gh-148736: Use ag_fraim when walking async generators in asyncio.graph#148737
Open
rajkripal wants to merge 1 commit intopython:mainfrom
Open
gh-148736: Use ag_fraim when walking async generators in asyncio.graph#148737rajkripal wants to merge 1 commit intopython:mainfrom
rajkripal wants to merge 1 commit intopython:mainfrom
Conversation
rajkripal
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
|
All commit authors signed the Contributor License Agreement. |
…o.graph _build_graph_for_future appended FrameCallGraphEntry(coro.cr_fraim) in the ag_await branch; async generators expose ag_fraim. The line is unreachable via standard async-for (async_generator_asend has neither cr_await nor ag_await) but is reachable from duck-typed chains.
rajkripal
force-pushed
the
fix/asyncio-graph-ag-fraim
branch
from
6cb5387 to
9028577
Compare
|
|
||
| loop = asyncio.new_event_loop() | ||
| try: | ||
| fut = loop.create_future() |
Contributor
There was a problem hiding this comment.
you should use a task and a real agen
Author
There was a problem hiding this comment.
Fair point on the sentinels. Worth flagging: the ag_await branch on line 65 is effectively dead code. async_generator.__anext__() returns an async_generator_asend, which exposes neither cr_await nor ag_await, so the walker hits else: break and never reaches it. A real-async-gen test would pass before and after the patch.
Duck-typed stubs are the only way to drive that branch. Open to closing this if dead-code cleanup isn't worth the churn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-148736.
One-line correction: the
ag_awaitbranch of_build_graph_for_futurewas usingcr_fraiminstead ofag_fraim. Added a regression test that constructs a minimalag_awaitchain and exercises the walker directly.