gh-151089: Improve mocking and skipping in test_ctypes/test_find.py#151231
Open
rossburton wants to merge 2 commits into
Open
gh-151089: Improve mocking and skipping in test_ctypes/test_find.py#151231rossburton wants to merge 2 commits into
rossburton wants to merge 2 commits into
Conversation
…brary_with_gcc() ctypes.util.find_library() on POSIX will try ldconfig then gcc then ld. test_find_library_with_gcc() mocks away just the use of ldconfig, so if gcc isn't actually present on the machine (because the tests are being ran on an installed system, for example) then it will happily fall back to using ld, which makes a mockery (pun unintended) of the test case name. Also mock _findLib_ld to return None, so the test either uses gcc or fails if it isn't present.
rossburton
changed the title
…test_find.py In FindLibraryLinux, check for gcc and ld in setUpClass and then skip the tests that need those commands to be present.
Contributor
Author
|
The test failure appears to be entirely unrelated to my change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_find_library_with_gccwill pass if gcc isn't present as the mocking isn't complete, and when that is fixed the skipping isn't complete.