Add missing attributes to json/decoder.pyi JSONDecoder#15333
Open
b9788213 wants to merge 4 commits intopython:mainfrom
Open
Add missing attributes to json/decoder.pyi JSONDecoder#15333b9788213 wants to merge 4 commits intopython:mainfrom
b9788213 wants to merge 4 commits intopython:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Jan 28, 2026
stdlib/json/decoder.pyi
Outdated
Comment on lines
+21
to
+24
| parse_object: Callable[..., Any] | ||
| parse_array: Callable[..., Any] | ||
| parse_string: Callable[..., Any] | ||
| memo: dict[Any, Any] |
Collaborator
There was a problem hiding this comment.
Thanks, but we should add the actual arguments and return types here. Same for the actual types in the memo dict. Alternatively, we could use Incomplete (from _typeshed) as a marker for now.
Contributor
Author
There was a problem hiding this comment.
Is there a good way to tell they are the same thing, or have we copy the signature of the functions
Collaborator
There was a problem hiding this comment.
I think copying the signature is fine where that makes sense.
Contributor
Author
There was a problem hiding this comment.
JSONArray and JSONObject wasnt exits so i tried implenting it but its so complex
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing attributes to json/decoder.pyi JSONDecoder class.