chore: pytest and rm bool

inspxctelement · inspxctelement · commit 83bd6488f1ff · 2024-05-13T20:22:46.000-04:00
diff --git a/src/validators/ip_address.py b/src/validators/ip_address.py
@@ -33,9 +33,9 @@ def _check_private_ip(value: str, is_private: Optional[bool]):
         or re.match(r"^172\.(?:1[6-9]|2\d|3[0-1])\.", value)  # private
         or re.match(r"^(?:22[4-9]|23[0-9]|24[0-9]|25[0-5])\.", value)  # broadcast
     ):
-        return bool(is_private)
+        return is_private
     else:
-        return not bool(is_private)
+        return not is_private
 
 
 @validator
diff --git a/tests/test_ip_address.py b/tests/test_ip_address.py
@@ -150,21 +150,6 @@ def test_returns_failed_validation_on_invalid_ipv6_cidr_address(
     assert isinstance(ipv6(address, cidr=cidr, strict=strict, host_bit=host_bit), ValidationError)
 
 
-@pytest.mark.parametrize(
-    ("address", "private"),
-    [
-        ("10.1.1.1", False),
-        ("192.168.1.1", False),
-        ("169.254.1.1", False),
-        ("127.0.0.1", False),
-        ("0.0.0.0", False),
-    ],
-)
-def test_returns_failed_validation_on_private_ipv4_address(address: str, private: bool):
-    """Test returns failed validation on invalid ipv4 CIDR address."""
-    assert isinstance(ipv4(address, private=private), ValidationError)
-
-
 @pytest.mark.parametrize(
     ("address", "private"),
     [
@@ -176,7 +161,7 @@ def test_returns_failed_validation_on_private_ipv4_address(address: str, private
     ],
 )
 def test_returns_valid_on_private_ipv4_address(address: str, private: bool):
-    """Test returns failed validation on invalid ipv4 CIDR address."""
+    """Test returns true on private ipv4 address."""
     assert ipv4(address, private=private)
 
 
@@ -188,8 +173,8 @@ def test_returns_valid_on_private_ipv4_address(address: str, private: bool):
         ("7.53.12.1", True),
     ],
 )
-def test_returns_failed_validation_on_not_private_ipv4_address(address: str, private: bool):
-    """Test returns failed validation on invalid ipv4 CIDR address."""
+def test_returns_failed_validation_on_invalid_private_ipv4_address(address: str, private: bool):
+    """Test returns failed validation on invalid private ipv4 address."""
     assert isinstance(ipv4(address, private=private), ValidationError)
 
 
@@ -201,6 +186,21 @@ def test_returns_failed_validation_on_not_private_ipv4_address(address: str, pri
         ("7.53.12.1", False),
     ],
 )
-def test_returns_valid_on_private_public_ipv4_address(address: str, private: bool):
-    """Test returns failed validation on invalid ipv4 CIDR address."""
+def test_returns_valid_on_public_ipv4_address(address: str, private: bool):
+    """Test returns true on valid public ipv4 address."""
     assert ipv4(address, private=private)
+
+
+@pytest.mark.parametrize(
+    ("address", "private"),
+    [
+        ("10.1.1.1", False),
+        ("192.168.1.1", False),
+        ("169.254.1.1", False),
+        ("127.0.0.1", False),
+        ("0.0.0.0", False),
+    ],
+)
+def test_returns_failed_validation_on_private_ipv4_address(address: str, private: bool):
+    """Test returns failed validation on private ipv4 address."""
+    assert isinstance(ipv4(address, private=private), ValidationError)
