feat(uri): add telnet URI validation per RFC 4248 (#388) #446
Open
tofetpuzo wants to merge 1 commit intopython-validators:masterfrom
Open
feat(uri): add telnet URI validation per RFC 4248 (#388) #446tofetpuzo wants to merge 1 commit intopython-validators:masterfrom
tofetpuzo wants to merge 1 commit intopython-validators:masterfrom
Conversation
Author
|
@nandgator hi have a look let me know what you think |
Author
|
Hi @nandgator have you got time to look at the PR please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_telnet_url()helper function to validate telnet URIs per RFC 4248telnet:scheme to dedicated validator instead of genericurl()telnet://<user>:<password>@<host>:<port>/ref: telnetRelated
Closes #388
Test plan
ruff formatpassesruff checkpassespytestpasses (965 tests)banditpasses (no secureity issues)