BREAKING: disabled implicit conversion from Python objects implementing sequence protocol to (#1902)

lostmsu · web-flow · commit 5f63c67af223 · 2022-08-08T23:02:19.000+02:00
.NET arrays when the target .NET type is `System.Object`. The conversion is still attempted when the target type is a `System.Array` fixes #1900
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -67,6 +67,9 @@ or the DLL must be loaded in advance. This must be done before calling any other
 -   BREAKING: disabled implicit conversion from C# enums to Python `int` and back.
 One must now either use enum members (e.g. `MyEnum.Option`), or use enum constructor
 (e.g. `MyEnum(42)` or `MyEnum(42, True)` when `MyEnum` does not have a member with value 42).
+-   BREAKING: disabled implicit conversion from Python objects implementing sequence protocol to
+.NET arrays when the target .NET type is `System.Object`. The conversion is still attempted when the
+target type is a `System.Array`.
 -   Sign Runtime DLL with a strong name
 -   Implement loading through `clr_loader` instead of the included `ClrModule`, enables
     support for .NET Core
diff --git a/src/runtime/Converter.cs b/src/runtime/Converter.cs
@@ -389,11 +389,6 @@ internal static bool ToManagedValue(BorrowedReference value, Type obType,
                     return true;
                 }
 
-                if (Runtime.PySequence_Check(value))
-                {
-                    return ToArray(value, typeof(object[]), out result, setError);
-                }
-
                 result = new PyObject(value);
                 return true;
             }
diff --git a/tests/test_conversion.py b/tests/test_conversion.py
@@ -577,6 +577,13 @@ class Foo(object):
     ob.ObjectField = Foo
     assert ob.ObjectField == Foo
 
+    class PseudoSeq:
+        def __getitem__(self, idx):
+           return 0
+
+    ob.ObjectField = PseudoSeq()
+    assert ob.ObjectField.__class__.__name__ == "PseudoSeq"
+
 
 def test_null_conversion():
     """Test null conversion."""

Original file line number	Diff line number	Diff line change
`@@ -389,11 +389,6 @@ internal static bool ToManagedValue(BorrowedReference value, Type obType,`
`389`	`389`	`return true;`
`390`	`390`	`}`
`391`	`391`
`392`		`- if (Runtime.PySequence_Check(value))`
`393`		`- {`
`394`		`- return ToArray(value, typeof(object[]), out result, setError);`
`395`		`- }`
`396`		`-`
`397`	`392`	`result = new PyObject(value);`
`398`	`393`	`return true;`
`399`	`394`	`}`