server: add support for graceful shutdown#139
Merged
Conversation
Also, rework e2e tests to use ephemeral ports.
The snapshot servers no longer provide these builds.
Bogdanp
force-pushed
the
master
branch
5 times, most recently
from
4b2e41b to
6be4684
Compare
Also, adjust the test to use serve to avoid needing to parse the output port to get the server's listening port.
Contributor
Author
|
I think the "gh3" failure is due to an incompatibility between old versions of Racket and new versions of OpenSSL. After some experimenting, I got the following error: https://github.com/Bogdanp/web-server/actions/runs/16388725990/job/46311858304#step:6:97 I'll push a change to add some more recent versions of Racket to the test matrix and to disable that test for older versions. |
Contributor
Author
|
👋 bump |
jeapostrophe
approved these changes
Jul 26, 2025
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new safety limit,
#:shutdown-grace-period, which controls how long the server will wait for in-progress connections to drain before shutting down. The current behaviour of shutting down immediately is preserved by default, so this change is opt-in.