step 3/6: chat UIホットパス最適化#365
step 3/6: chat UIホットパス最適化#365meganetaaan wants to merge 2 commits intostep-pr/02-chat-foundationfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db759121f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const chatConfig = { | ||
| ...config.chat, | ||
| instructions: 'あなたは丁寧なアシスタントロボットです。', | ||
| specifier: 'openAIRealtime', |
There was a problem hiding this comment.
Hard-coding specifier: 'openAIRealtime' after spreading config.chat overrides any provider selected in mc/config, so deployments configured for deepgramAgent/elevenLabsAgent/etc. will now instantiate the wrong backend and fail at runtime. This also makes the subsequent if (!chatConfig?.specifier) guard effectively unreachable, masking missing-config detection.
Useful? React with 👍 / 👎.
| // onInputTranscript: (text, more) => { | ||
| // onTranscript(text, more) | ||
| // }, |
There was a problem hiding this comment.
Commenting out onInputTranscript stops user-side transcript events from reaching onTranscript, so the balloon no longer reflects recognized input while the user is speaking and only output transcript updates are shown. This is a behavior regression in the chat UI path and removes real-time feedback needed to verify ASR recognition.
Useful? React with 👍 / 👎.
1 participant
Summary
Scope
step-pr/02-chat-foundationstep-pr/03-chat-ui-hotpathNotes