Add multiline exclude_pattern support via exclude_pattern_context_lines#47
Open
edengilbertus wants to merge 2 commits intozulip:mainfrom
Open
Add multiline exclude_pattern support via exclude_pattern_context_lines#47edengilbertus wants to merge 2 commits intozulip:mainfrom
edengilbertus wants to merge 2 commits intozulip:mainfrom
Conversation
Fixes zulip#30: custom_rules matches based on multiline patterns can now exclude based on multiline matching. Added 'exclude_pattern_context_lines' key to Rule, which specifies how many additional lines after the match to include when evaluating exclude_pattern. This enables exclude_pattern to inspect content beyond the matched lines for context-aware exclusions. Default is 0 (unchanged behavior). Fully backward-compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30: custom_rules matches based on multiline patterns can now exclude based on multiline matching.
Added 'exclude_pattern_context_lines' key to Rule, which specifies how many additional lines after the match to include when evaluating exclude_pattern enabling exclude_pattern to inspect content beyond the matched lines for context aware exclusions