message-list: Handle fetchInitial error with retry UI#2118
Open
Rozerxshashank wants to merge 1 commit intozulip:mainfrom
Open
message-list: Handle fetchInitial error with retry UI#2118Rozerxshashank wants to merge 1 commit intozulip:mainfrom
Rozerxshashank wants to merge 1 commit intozulip:mainfrom
Conversation
Rozerxshashank
force-pushed
the
amsglst
branch
from
f9b8e23 to
05e76c7
Compare
Author
|
Gey @chrisbobbe , I raised this pr few days ago can you please review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the initial batch of messages fails to load (e.g., network error), the app currently shows an infinite loading spinner. This PR adds proper error handling to show an error message with a Try again button instead.
Manually tested by:
Fixes: msglist: When we fail to load the initial batch of messages, don't show infinite loading spinner #2085
after.mp4