Content-Length: 320551 | pFad | http://github.com/WebKit/WebKit/pull/15443

2C [CSS Container Queries] Use element writing mode for unit resolution by anttijk · Pull Request #15443 · WebKit/WebKit · GitHub
Skip to content

[CSS Container Queries] Use element writing mode for unit resolution #15443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

[CSS Container Queries] Use element writing mode for unit resolution #15443

merged 1 commit into from
Jun 30, 2023

Conversation

anttijk
Copy link
Contributor

@anttijk anttijk commented Jun 30, 2023 •
edited by webkit-early-warning-system
Loading

b4d32d7

[CSS Container Queries] Use element writing mode for unit resolution
https://bugs.webkit.org/show_bug.cgi?id=258722
rdar://111565488

Reviewed by Simon Fraser.

Correct handling for vertical writing mode per w3c/csswg-drafts#6873

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-in-at-container-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-selection-expected.txt:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):

Resolve logical to to physical axis based on the element writing mode.
Also explicitly fall back to small viewport units to guarantee consistency.

Canonical link: https://commits.webkit.org/265654@main

8654810

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk self-assigned this Jun 30, 2023
@anttijk anttijk added the CSS Cascading Style Sheets implementation label Jun 30, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 30, 2023 •
edited
Loading

EWS run on previous version of this PR (hash b9f8828)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk force-pushed the cq-unit-vertical branch from b9f8828 to dfa9b33 Compare June 30, 2023 13:51
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 30, 2023 •
edited
Loading

EWS run on previous version of this PR (hash dfa9b33)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk force-pushed the cq-unit-vertical branch from dfa9b33 to 8654810 Compare June 30, 2023 14:04
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 30, 2023 •
edited
Loading

EWS run on current version of this PR (hash 8654810)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk added the merge-queue Applied to send a pull request to merge-queue label Jun 30, 2023
@anttijk
[CSS Container Queries] Use element writing mode for unit resolution
b4d32d7 
https://bugs.webkit.org/show_bug.cgi?id=258722
rdar://111565488

Reviewed by Simon Fraser.

Correct handling for vertical writing mode per w3c/csswg-drafts#6873

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-in-at-container-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-selection-expected.txt:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):

Resolve logical to to physical axis based on the element writing mode.
Also explicitly fall back to small viewport units to guarantee consistency.

Canonical link: https://commits.webkit.org/265654@main
@webkit-commit-queue
Copy link
Collaborator

Committed 265654@main (b4d32d7): https://commits.webkit.org/265654@main

Reviewed commits have been landed. Closing PR #15443 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b4d32d7 into WebKit:main Jun 30, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 30, 2023
@anttijk anttijk deleted the cq-unit-vertical branch June 30, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr

Assignees

@anttijk anttijk

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anttijk @webkit-early-warning-system @webkit-commit-queue @smfr








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/WebKit/WebKit/pull/15443

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy