[CSS Math Functions] NaN numeric representation should be 0 (not Infinity) #15677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 394316e)
|
darinadler
approved these changes
Jul 9, 2023
| if (primitiveType() == CSSUnitType::CSS_DEG && (isnan(value) || isinf(value))) | ||
| value = CSSCalcOperationNode::convertToTopLevelValue(value); | ||
| // If an <angle> must be converted due to exceeding the implementation-defined range of supported values, | ||
| // it must be clamped to the nearest supported multiple of 360deg. |
There was a problem hiding this comment.
Why is 0 the nearest supported multiple of 360deg to infinity and -infinity?
There was a problem hiding this comment.
I guess it would be 360 or -360 which are equivalent to 0
There was a problem hiding this comment.
That’s not literally correct (360deg would not be the nearest multiple of 360deg to infinity), but if this is modulo 360deg then clearly any multiple is equivalent to 0deg. But that was not obvious to me.
darinadler
approved these changes
Jul 9, 2023
webkit-ews-buildbot
added
merging-blocked
nt1m
force-pushed
the
eng/CSS-Math-Functions-NaN-numeric-representation-should-be-0-not-Infinity
branch
from
394316e to
9153ccd
Compare
|
EWS run on current version of this PR (hash 9153ccd)
|
…nity) https://bugs.webkit.org/show_bug.cgi?id=259034 rdar://111984451 Reviewed by Darin Adler. This changed in w3c/csswg-drafts@b5113b9 Discussion was at w3c/csswg-drafts#7067 * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-function-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-lab-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-function-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-lab-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-values/calc-infinity-nan-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-serialize-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-values/signs-abs-computed-expected.txt: * Source/WebCore/css/calc/CSSCalcOperationNode.h: * Source/WebCore/css/calc/CSSCalcValue.cpp: (WebCore::CSSCalcValue::clampToPermittedRange const): Canonical link: https://commits.webkit.org/265891@main
webkit-commit-queue
force-pushed
the
eng/CSS-Math-Functions-NaN-numeric-representation-should-be-0-not-Infinity
branch
from
9153ccd to
c7b1f51
Compare
|
Committed 265891@main (c7b1f51): https://commits.webkit.org/265891@main Reviewed commits have been landed. Closing PR #15677 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
nt1m
deleted the
eng/CSS-Math-Functions-NaN-numeric-representation-should-be-0-not-Infinity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c7b1f51
9153ccd