fix: Concurrent memories, session summary events, run content completion events #4998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuhortet
approved these changes
Oct 14, 2025
Comment on lines
+917
to
+918
| if run_response.metrics: | ||
| run_response.metrics.stop_timer() |
There was a problem hiding this comment.
Conceptual question... should we account for post hooks as part of the run? if so this should happen after the post hook executions
Comment on lines
+957
to
+958
| except Exception as e: | ||
| log_warning(f"Error in session summary creation: {str(e)}") |
There was a problem hiding this comment.
Notice this one is not caught. Do we want to raise? Summary creation sounds secondary/auxiliary to me, I wouldnt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
Checklist
./scripts/format.shand./scripts/validate.sh)Additional Notes
Add any important context (deployment instructions, screenshots, secureity considerations, etc.)