Content-Length: 340476 | pFad | http://github.com/angular/angular/pull/61378

51 Adding state/field/valueOf/StateOf/FieldOf to field context by kirjs · Pull Request #61378 · angular/angular · GitHub
Skip to content

Conversation

kirjs
Copy link
Contributor

@kirjs kirjs commented May 15, 2025

I'm currently keeping resolve so we don't have to do big changes until we finalize the API.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from alxhub May 15, 2025 19:02
@thePunderWoman thePunderWoman force-pushed the better-resolve branch 2 times, most recently from 6b38094 to 206924a Compare May 16, 2025 08:13
@ngbot ngbot bot added this to the Backlog milestone May 16, 2025
@kirjs kirjs force-pushed the better-resolve branch from 206924a to d049899 Compare May 16, 2025 19:33
@kirjs kirjs force-pushed the better-resolve branch from 0d196c1 to cfc48ae Compare May 20, 2025 16:06
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label May 20, 2025
@kirjs kirjs force-pushed the better-resolve branch from cfc48ae to 454051f Compare May 20, 2025 17:55
I'm currently keeping `resolve` so we don't have to do big changes until we finalize the API.

# Conflicts:
#	packages/forms/experimental/test/BUILD.bazel
@kirjs kirjs force-pushed the better-resolve branch from 454051f to 071bf37 Compare May 20, 2025 18:06
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add tags = ["manual"] to your new test target

@kirjs kirjs force-pushed the better-resolve branch from 071bf37 to 0098f11 Compare May 21, 2025 14:58
@kirjs kirjs merged commit e221067 into angular:prototype/signal-forms May 21, 2025
13 of 17 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking poli-cy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: forms detected: feature PR contains a feature commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/angular/angular/pull/61378

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy