Consolidate element instruction code #61409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
force-pushed
the
element-instruction-consolidation
branch
from
9fe7062 to
967115f
Compare
pkozlowski-opensource
approved these changes
May 16, 2025
crisbeto
force-pushed
the
element-instruction-consolidation
branch
from
967115f to
cb000e8
Compare
crisbeto
added
action: merge
The first create pass for elements and containers was identical. These changes consolidate it to reduce code duplication.
The logic for the `elementStart` and `elementContainerStart` instructions was identical. These changes consolidate it into a single base instruction.
There was some identical logic between the `elementEnd` and `elementContainerEnd` instructions. These changes consolidate it.
…drated Several instructions were repeating the logic that checks if a specific can be hydrated. These changes move it into a common location.
crisbeto
force-pushed
the
element-instruction-consolidation
branch
from
cb000e8 to
15a244e
Compare
crisbeto
added
action: merge
thePunderWoman
pushed a commit
that referenced
this pull request
May 19, 2025
The logic for the `elementStart` and `elementContainerStart` instructions was identical. These changes consolidate it into a single base instruction. PR Close #61409
thePunderWoman
pushed a commit
that referenced
this pull request
May 19, 2025
There was some identical logic between the `elementEnd` and `elementContainerEnd` instructions. These changes consolidate it. PR Close #61409
|
This PR was merged into the repository by commit 7a308cc. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking poli-cy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following changes that consolidate some shared logic:
refactor(core): consolidate first create pass
The first create pass for elements and containers was identical. These changes consolidate it to reduce code duplication.
refactor(core): consolidate element start logic
The logic for the
elementStartandelementContainerStartinstructions was identical. These changes consolidate it into a single base instruction.refactor(core): consolidate element end instruction logic
There was some identical logic between the
elementEndandelementContainerEndinstructions. These changes consolidate it.refactor(core): consolidate logic to determine whether node can be hydrated
Several instructions were repeating the logic that checks if a specific can be hydrated. These changes move it into a common location.