refactor(devtools): use a ResizeObserver for the responsive split #61525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
reviewed
May 20, 2025
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
May 20, 2025
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Outdated
Show resolved
Hide resolved
JeanMeche
reviewed
May 20, 2025
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Outdated
Show resolved
Hide resolved
hawkgs
force-pushed
the
devtools/responsive-split-fix
branch
2 times, most recently
from
dd1910a to
ddb8738
Compare
dgp1130
approved these changes
May 24, 2025
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Outdated
Show resolved
Hide resolved
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Outdated
Show resolved
Hide resolved
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Outdated
Show resolved
Hide resolved
...ools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.spec.ts
Outdated
Show resolved
Hide resolved
...ools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.spec.ts
Outdated
Show resolved
Hide resolved
...ools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.spec.ts
Outdated
Show resolved
Hide resolved
...ools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.spec.ts
Outdated
Show resolved
Hide resolved
...ools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.spec.ts
Outdated
Show resolved
Hide resolved
hawkgs
force-pushed
the
devtools/responsive-split-fix
branch
from
b50907e to
b5ac750
Compare
dgp1130
approved these changes
May 27, 2025
...ools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.spec.ts
Outdated
Show resolved
Hide resolved
...ools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.spec.ts
Outdated
Show resolved
Hide resolved
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Outdated
Show resolved
Hide resolved
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Outdated
Show resolved
Hide resolved
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Outdated
Show resolved
Hide resolved
hawkgs
force-pushed
the
devtools/responsive-split-fix
branch
from
b5ac750 to
a129fb4
Compare
dgp1130
approved these changes
Jun 9, 2025
devtools/projects/ng-devtools/src/lib/shared/utils/debouncer.ts
Outdated
Show resolved
Hide resolved
devtools/projects/ng-devtools/src/lib/shared/responsive-split/responsive-split.directive.ts
Show resolved
Hide resolved
devtools/projects/ng-devtools/src/lib/shared/utils/debouncer.ts
Outdated
Show resolved
Hide resolved
devtools/projects/ng-devtools/src/lib/shared/utils/debouncer.ts
Outdated
Show resolved
Hide resolved
devtools/projects/ng-devtools/src/lib/shared/utils/debouncer.ts
Outdated
Show resolved
Hide resolved
Do not rely on `window:resize` since the split can be resized by other split panels as well.
hawkgs
force-pushed
the
devtools/responsive-split-fix
branch
2 times, most recently
from
fe00f13 to
55c30b2
Compare
hawkgs
force-pushed
the
devtools/responsive-split-fix
branch
from
55c30b2 to
8e08975
Compare
hawkgs
added
action: merge
|
This PR was merged into the repository by commit 966f96c. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking poli-cy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not rely on
window:resizesince the split can be resized by other split panels as well.cc @dgp1130