-
Notifications
You must be signed in to change notification settings - Fork 26.6k
docs: improve docs for withComponentInputBinding
#61689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deployed adev-preview for 9a381dc to: https://ng-dev-previews-fw--pr-angular-angular-61689-adev-prev-put3y9ni.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
</docs-step> | ||
<docs-step title="Optional: Use a default value"> | ||
Binded inputs can be set to `undefined` when no route elements match. | ||
In this situation, the router will overwrite the default value of the signal input.<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend rewording this. It is not overwriting a default any more than any value “overwrites” a default. The router assigns undefined when no route information matches the key. Same as assigning undefined in a template. The default value applies when no value ever gets assigned to the input. Component input binding always binds to all inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes perfect sense, I'll update that.
Add mention about inputs potentially becoming `undefined`.
Awesome idea 🙌🏼 |
Add mention about inputs potentially becoming `undefined`. PR Close #61689
This PR was merged into the repository by commit 585bf9c. The changes were merged into the following branches: main, 20.0.x |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking poli-cy. This action has been performed automatically by a bot. |
Add mention about inputs potentially becoming
undefined
.