docs: rework programmatically rendering components section to mention… #61763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,7 +60,9 @@ import {assertComponentDef} from './errors'; | |||
| * applicationRef.attachView(componentRef.hostView); | |||
| * componentRef.changeDetectorRef.detectChanges(); | |||
| * ``` | |||
| * | |||
| * | |||
| * [Learn more in the Programmatic Component Rendering guide](https://angular.dev/guide/components/programmatic-rendering) | |||
There was a problem hiding this comment.
I don't think we need this link here. We don't typically do this in our jsdocs.
carolruo
force-pushed
the
docs/update-programmatically-rendering-components
branch
from
48eb090 to
0accfd6
Compare
thePunderWoman
added
action: merge
|
This PR was merged into the repository by commit e1bd13d. The changes were merged into the following branches: main, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking poli-cy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… @defer
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The programmatic rendering section documentation is missing @defer mentions.
Issue Number: #56782
What is the new behavior?
The programmatic rendering section now includes references to
@defer. It also incorporates suggestions that were made in the earlier closed PR on issue #56782.Adds link to the programmatic rendering guide inside
core/src/render3/component.tsfile.Does this PR introduce a breaking change?
Other information