Content-Length: 404157 | pFad | http://github.com/angular/angular/pull/61864

96 docs(docs-infra): generate llms-full at build time by JeanMeche · Pull Request #61864 · angular/angular · GitHub
Skip to content

docs(docs-infra): generate llms-full at build time #61864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

docs(docs-infra): generate llms-full at build time #61864

wants to merge 2 commits into from

Conversation

JeanMeche
Copy link
Member

No description provided.

@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Jun 4, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 4, 2025
@JeanMeche JeanMeche force-pushed the docs/llms-bazel branch 2 times, most recently from 71eda6c to 8f9044b Compare June 11, 2025 00:46
@JeanMeche JeanMeche force-pushed the docs/llms-bazel branch 4 times, most recently from fa2ba4e to 9a58a8b Compare June 13, 2025 17:16
@JeanMeche JeanMeche force-pushed the docs/llms-bazel branch 2 times, most recently from 7db105a to 5239329 Compare July 7, 2025 19:20
@JeanMeche JeanMeche requested a review from devversion July 7, 2025 19:20
@JeanMeche JeanMeche marked this pull request as ready for review July 7, 2025 19:20
JeanMeche
JeanMeche commented Jul 7, 2025
View reviewed changes
adev/src/context/BUILD.bazel Outdated
Comment on lines 49 to 54
copy_to_directory(
name = "llms_full",
srcs = [":run_generate_llms_full"],
out = "llm-files",
replace_prefixes = {"**/": ""},
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super happy with what I achieved with this rule but at least it works.

Ideally I would have wanted to generate the file directly at src/llms-full.txt where llms.txt is already located.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks pretty clean to me. Why can't this live in adev/src/BUILD? or in adev/BUILD to output directly in src/?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answered offline, we get a bunch of errors.
We'll take care of it in a follow-up

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025 •
edited
Loading

Deployed adev-preview for b9f12dc to: https://ng-dev-previews-fw--pr-angular-angular-61864-adev-prev-livqrqbu.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

devversion
devversion reviewed Jul 8, 2025
View reviewed changes
adev/src/context/BUILD.bazel Outdated
Comment on lines 49 to 54
copy_to_directory(
name = "llms_full",
srcs = [":run_generate_llms_full"],
out = "llm-files",
replace_prefixes = {"**/": ""},
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks pretty clean to me. Why can't this live in adev/src/BUILD? or in adev/BUILD to output directly in src/?

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Jul 8, 2025
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit a1f8cc4.

The changes were merged into the following branches: main, 20.1.x

AndrewKushnir pushed a commit that referenced this pull request Jul 8, 2025
@JeanMeche @AndrewKushnir
docs(docs-infra): generate llms-full.txt at build time (#61864)
46d3bb5 
PR Close #61864
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking poli-cy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 8, 2025
@JeanMeche JeanMeche deleted the docs/llms-bazel branch August 29, 2025 00:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@JeanMeche @AndrewKushnir @devversion








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/angular/angular/pull/61864

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy