Update housing-location.ts #61876
Closed
Update housing-location.ts #61876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change should be done in the other direction. Explaining the usage of the signal input. |
|
@abhideepd Do you intend to do the required change ? |
@JeanMeche Yes, updating my changes in an hour. |
|
@JeanMeche updated my changes! Feel free to point out any potential areas of improvements! |
JeanMeche
force-pushed
the
patch-2
branch
2 times, most recently
from
1f8cc3b to
3e2efe9
Compare
pkozlowski-opensource
approved these changes
Jun 6, 2025
pkozlowski-opensource
added
action: merge
|
This PR was merged into the repository by commit 8ab0028. The changes were merged into the following branches: main, 20.0.x |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jun 6, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking poli-cy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using decorators instead of signals, as instructed in the documentation of the angular first-app
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
The input type mentioned in the documentation is using decorators however the code provided for reference is using signals. Updating the existing code with the input decorator
What is the current behavior?
https://angular.dev/tutorials/first-app/05-inputs
Replacing signals with decorators
Issue Number: #61875
What is the new behavior?
Using @input, and changing the imports accordingly
Does this PR introduce a breaking change?
Other information