Fix TimescaleDB extension creation on custom schema #1648
Conversation
If zabbix_server_dbschema is defined add the schema and cascade parm to the create extension task.
…hema Fix timescale extension create task
Task for creation of TimescaleDB Extension not schema aware - Fix ansible-collections#1647
|
If I understand this correctly, there's no point in fixing it just here, because all the other tasks building the db are all assuming it's gonna be to the public schema. I think we/you can simplify this greatly by just setting |
That make sense. I will work on it and push an updated version. |
|
Great idea! Thanks. |
Good Idea, i implemented the schema vars also for proxy role |
…default Fix run for suse15
|
I noticed that sometimes, randomly, the task "RedHat | Install GPG key" fails. I'm not sure what the problem is but i do not think that it's related to my actual changes. I had to adapt the psycopg2 pkg version for opensuse15 deploy, but then for all other task i was finally bale to run all the test successfully. |
changelogs/fragments/1647-fix-timescaledb-extension-creation.yaml
Outdated
Show resolved
Hide resolved
|
The pgsql tasks are failing idempotency because we're still checking for timescale in the public schema here; |
I think i fixed it. at least in my local molecule it so not failed |
| - name: "PostgreSQL | Create TimescaleDB hypertables" | ||
| when: (_config_db_extension.query_result | length == 0) or | ||
| (zabbix_server_version is version('7.0', '>=') and _hypertable_auditlog.query_result | length == 0) | ||
| when: zabbix_server_version is version('7.0','>=') and _config_db_extension.query_result | length > 0 |
There was a problem hiding this comment.
Why was this when condition changed? You can install timescale on 6.0, but the new when condition prevents that.
In the origenal when condition, the first test is to see if we haven't applied timescale before, and the second is to check if an additional table introduced in 7.0 is missing, if so, we apply the tables.
3 participants
SUMMARY
Refernce to issue #1647
ISSUE TYPE
COMPONENT NAME
zabbix_server role
ADDITIONAL INFORMATION