Content-Length: 298010 | pFad | http://github.com/mdn/content/pull/26361

06 Update the description and the example for the CSS function `tan()` by yarusome · Pull Request #26361 · mdn/content · GitHub
Skip to content

Update the description and the example for the CSS function tan() #26361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

yarusome
Copy link
Contributor

Description

This PR:

  1. Changes the description for the special behavior of tan() when inputs are asymptote values following [css-values] Consider removing asymptotic special-cases for tan() w3c/csswg-drafts#8527;
  2. Slightly changes the structure of the example;
  3. Makes grammatic corrections.

Motivation

For the example:

  1. The current expression for --angle in the example, i.e. calc(sin(var(--h) / var(--w))), makes on sense in that it uses a sine value as an angle.
  2. skew() is explicitly deprecated by the spec.
  3. The use of a bare 0 to mean 0deg is deemed legacy by the spec.

This also blocks the l10n of this page.

Additional details

Related issues and pull requests

@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Apr 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2023

Preview URLs

(comment last updated: 2023-04-24 06:07:09)

@yarusome yarusome marked this pull request as ready for review April 22, 2023 10:19
@yarusome yarusome requested a review from a team as a code owner April 22, 2023 10:19
@yarusome yarusome requested review from estelle and removed request for a team April 22, 2023 10:19
@yarusome
Copy link
Contributor Author

Btw, where's the guideline that emphases should only be wrapped in underscores? I couldn't find it in How to write in Markdown.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/mdn/content/pull/26361

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy