Test that lh units are calculated before select fixup #36457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 14, 2022
Per resolution in [1], lh units should be computed before any fixups to line-height for form controls. Add a test for <select> elements. [1] w3c/csswg-drafts#3257 (comment) Bug: 937104 Change-Id: Id9987dc1d9a2c7b7a6e006cbfdd431e07379196b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3955838 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1059314}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3955838
branch
from
fe2d433 to
6730ce1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per resolution in [1], lh units should be computed before any fixups to
line-height for form controls. Add a test for <select> elements.
[1] w3c/csswg-drafts#3257 (comment)
Bug: 937104
Change-Id: Id9987dc1d9a2c7b7a6e006cbfdd431e07379196b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3955838
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1059314}