Fix "end" option in print func#90
Merged
Merged
Conversation
Fix line 190 to 193. The print function corrected the end option not applied. Added code performed when "end" value of parameter "kwargs" is not "nil".
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
+ Coverage 68.93% 68.94% +<.01%
==========================================
Files 60 60
Lines 10624 10626 +2
==========================================
+ Hits 7324 7326 +2
Misses 2782 2782
Partials 518 518
Continue to review full report at Codecov.
|
corona10
requested changes
Sep 26, 2019
Collaborator
corona10
left a comment
corona10
left a comment
There was a problem hiding this comment.
@Sungmin-Joo
Thank you for your contribution!!!
We need the unit test for this changed.
here is the reference
gpython/builtin/tests/builtin.py
Line 300 in 70a66f2
you can check your logic through file read
Fix line 190 to 193. The print function corrected the end option not applied. Added code performed when "end" value of parameter "kwargs" is not "nil".
add "end" option test in line 312
add "end" option test add "end" option test in line 312
corona10
approved these changes
Sep 26, 2019
Collaborator
corona10
left a comment
corona10
left a comment
There was a problem hiding this comment.
@Sungmin-Joo Thank for your contribution!
LGTM
|
@Sungmin-Joo |
This was referenced Sep 28, 2019
corona10
added a commit
that referenced
this pull request
Sep 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
line 190 to 193.
I tried to apply the end option to the print function.
Added code performed when "end" value of parameter "kwargs" is not "nil".