gh-99113: Add a check for Py_MOD_PER_INTERPRETER_GIL_SUPPORTED#104206
Merged
ericsnowcurrently merged 9 commits intopython:mainfrom May 6, 2023
Merged
gh-99113: Add a check for Py_MOD_PER_INTERPRETER_GIL_SUPPORTED#104206ericsnowcurrently merged 9 commits intopython:mainfrom
ericsnowcurrently merged 9 commits intopython:mainfrom
Conversation
ericsnowcurrently
requested review from
a team,
1st1,
AlexWaygood,
Fidget-Spinner,
JelleZijlstra,
abalkin,
asvetlov,
berkerpeksag,
brettcannon,
corona10,
erlend-aasland,
gpshead,
gvanrossum,
isidentical,
kumaraditya303,
ncoghlan,
pablogsal,
pganssle,
rhettinger,
tiran,
warsaw and
willingc
as code owners
ericsnowcurrently
removed request for
a team,
berkerpeksag,
brettcannon and
gpshead
3 tasks
ericsnowcurrently
force-pushed
the
own-gil-extension-check
branch
from
9cd8840 to
78b6ae7
Compare
ericsnowcurrently
added a commit
that referenced
this pull request
May 5, 2023
ericsnowcurrently
force-pushed
the
own-gil-extension-check
branch
from
78b6ae7 to
e2ddc27
Compare
erlend-aasland
approved these changes
May 6, 2023
Contributor
erlend-aasland
left a comment
erlend-aasland
left a comment
There was a problem hiding this comment.
LGTM
BTW, the branch in lines 295-300 seems lack coverage (disclaimer: I only ran test_import)
Member
Author
|
Thanks for pointing out about the missing test coverage. I've added it. I also did likewise for the similar case where |
Contributor
Nice, thanks! I can confirm that those branches are now covered. |
jbower-fb
pushed a commit
to jbower-fb/cpython
that referenced
this pull request
May 8, 2023
…4205) Here we are doing no more than adding the value for Py_mod_multiple_interpreters and using it for stdlib modules. We will start checking for it in pythongh-104206 (once PyInterpreterState.ceval.own_gil is added in pythongh-104204).
jbower-fb
pushed a commit
to jbower-fb/cpython
that referenced
this pull request
May 8, 2023
…ythongh-104206) Py_MOD_PER_INTERPRETER_GIL_SUPPORTED is a new supported value for Py_mod_multiple_interpreters, added in pythongh-104205.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Py_MOD_PER_INTERPRETER_GIL_SUPPORTEDis a new supported value forPy_mod_multiple_interpreters, added in gh-104205.(This is blocked until
PyInterpreterState.ceval.own_gilis added in gh-104204.)