Content-Length: 363984 | pFad | https://github.com/python/cpython/pull/110277

5B gh-110276: Run `test_str`, not `test_unicode`, as part of the PGO build by AlexWaygood · Pull Request #110277 · python/cpython · GitHub
Skip to content

gh-110276: Run test_str, not test_unicode, as part of the PGO build#110277

Merged
AlexWaygood merged 1 commit into
python:mainfrom
AlexWaygood:no-more-test-unicode
Oct 3, 2023
Merged

gh-110276: Run test_str, not test_unicode, as part of the PGO build#110277
AlexWaygood merged 1 commit into
python:mainfrom
AlexWaygood:no-more-test-unicode

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Oct 3, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Oct 3, 2023
Closed
@AlexWaygood

AlexWaygood commented Oct 3, 2023

Copy link
Copy Markdown
Member Author

Skipping news, since this issue only occurs on the main branch (and we don't usually include news entries for changes in Lib/test/ anyway).

@AlexWaygood AlexWaygood requested a review from hugovk October 3, 2023 12:18
@AlexWaygood AlexWaygood merged commit dddc757 into python:main Oct 3, 2023
@AlexWaygood AlexWaygood deleted the no-more-test-unicode branch October 3, 2023 12:54
@AlexWaygood

AlexWaygood commented Oct 3, 2023

Copy link
Copy Markdown
Member Author

Thanks @sobolevn!

@bedevere-bot

bedevere-bot commented Oct 3, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit dddc757.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/5833) and take a look at the build logs.
  4. Check if the failure is related to this commit (dddc757) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/5833

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1067, in _bootstrap_inner
    self.run()
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1004, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_interpreters.py", line 584, in task
    interp = interpreters.create()
             ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/interpreters.py", line 26, in create
    id = _interpreters.create(isolated=isolated)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: interpreter creation failed
k


Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1354, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1325, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 929, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1004, in exec_module
  File "<frozen importlib._bootstrap_external>", line 1100, in get_code
  File "<frozen importlib._bootstrap_external>", line 1199, in get_data
TypeError: descriptor 'close' for '_io.BufferedReader' objects doesn't apply to a '_io.FileIO' object

@sobolevn sobolevn mentioned this pull request Oct 3, 2023
Open
@bedevere-bot

bedevere-bot commented Oct 3, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO 3.x has failed when building commit dddc757.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/338/builds/5238) and take a look at the build logs.
  4. Check if the failure is related to this commit (dddc757) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/338/builds/5238

Failed tests:

  • test.test_concurrent_futures.test_shutdown

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 10, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Compressing objects:  16% (1/6)        
remote: Compressing objects:  33% (2/6)        
remote: Compressing objects:  50% (3/6)        
remote: Compressing objects:  66% (4/6)        
remote: Compressing objects:  83% (5/6)        
remote: Compressing objects: 100% (6/6)        
remote: Compressing objects: 100% (6/6), done.        
remote: Total 10 (delta 5), reused 4 (delta 4), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to 'dddc757303c6512915ef79b9029213415f1c6f1b'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at dddc757303 gh-110276: Run `test_str`, not `test_unicode`, as part of the PGO build (#110277)
Switched to and reset branch 'main'

./Modules/_xxinterpchannelsmodule.c:104:1: warning: ‘get_module_from_owned_type’ defined but not used [-Wunused-function]
 get_module_from_owned_type(PyTypeObject *cls)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~

make: *** [Makefile:2020: buildbottest] Error 5

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AlexWaygood @Glyphack
pythongh-110276: Run test_str, not test_unicode, as part of the P…
b417e23 
…GO build (python#110277)

`test_unicode` does not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

@hugovk hugovk Awaiting requested review from hugovk

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexWaygood @bedevere-bot @sobolevn








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/pull/110277

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy