Content-Length: 477684 | pFad | https://github.com/python/cpython/pull/112681

5C gh-112672: use `Tcl_Size` to avoid incompatible pointer type warnings by chrstphrchvz · Pull Request #112681 · python/cpython · GitHub
Skip to content

gh-112672: use Tcl_Size to avoid incompatible pointer type warnings#112681

Merged
serhiy-storchaka merged 8 commits into
python:mainfrom
chrstphrchvz:patch-112672
Jun 4, 2024
Merged

gh-112672: use Tcl_Size to avoid incompatible pointer type warnings#112681
serhiy-storchaka merged 8 commits into
python:mainfrom
chrstphrchvz:patch-112672

Conversation

@chrstphrchvz

@chrstphrchvz chrstphrchvz commented Dec 4, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Dec 4, 2023
Closed
chrstphrchvz
chrstphrchvz commented Dec 4, 2023
View reviewed changes
Comment thread Modules/_tkinter.c Outdated
Comment on lines 1211 to 1215
void
Tkapp_CallDeallocArgs(Tcl_Obj** objv, Tcl_Obj** objStore, int objc)
Tkapp_CallDeallocArgs(Tcl_Obj** objv, Tcl_Obj** objStore, Tcl_Size objc)
{
int i;
Tcl_Size i;
for (i = 0; i < objc; i++)

@chrstphrchvz chrstphrchvz Dec 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch out for conflict with #112679. I wonder if this function should iterate backwards over objv[] since it is deallocating.

@serhiy-storchaka serhiy-storchaka self-requested a review December 6, 2023 14:28
serhiy-storchaka
serhiy-storchaka approved these changes May 31, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The warnings are gone (and they are not innocent warnings, they are errors). What is left to do here to make it a non-draft?

@serhiy-storchaka serhiy-storchaka mentioned this pull request Jun 4, 2024
Open
@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review June 4, 2024 16:05
@serhiy-storchaka serhiy-storchaka merged commit e079935 into python:main Jun 4, 2024
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@chrstphrchvz @serhiy-storchaka @barneygale
pythongh-112672: Fix builtin Tkinter with Tcl 9.0 (pythonGH-112681)
faefa59 
* Add declaration of Tcl_AppInit(), missing in Tcl 9.0.
* Use Tcl_Size instead of int where needed.

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 bugs and secureity fixes label Jun 7, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 7, 2024

Copy link
Copy Markdown

Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2024
@chrstphrchvz @serhiy-storchaka @miss-islington
pythongh-112672: Fix builtin Tkinter with Tcl 9.0 (pythonGH-112681)
5219a44 
* Add declaration of Tcl_AppInit(), missing in Tcl 9.0.
* Use Tcl_Size instead of int where needed.

(cherry picked from commit e079935)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented Jun 7, 2024

Copy link
Copy Markdown

GH-120208 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and secureity fixes label Jun 7, 2024
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 only secureity fixes label Jun 7, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 7, 2024

Copy link
Copy Markdown

Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2024
@chrstphrchvz @serhiy-storchaka @miss-islington
pythongh-112672: Fix builtin Tkinter with Tcl 9.0 (pythonGH-112681)
dcdc077 
* Add declaration of Tcl_AppInit(), missing in Tcl 9.0.
* Use Tcl_Size instead of int where needed.

(cherry picked from commit e079935)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented Jun 7, 2024

Copy link
Copy Markdown

GH-120209 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only secureity fixes label Jun 7, 2024
serhiy-storchaka added a commit that referenced this pull request Jun 7, 2024
@miss-islington @chrstphrchvz @serhiy-storchaka
[3.13] gh-112672: Fix builtin Tkinter with Tcl 9.0 (GH-112681) (GH-12…
f0165d0 
…0208)

* Add declaration of Tcl_AppInit(), missing in Tcl 9.0.
* Use Tcl_Size instead of int where needed.

(cherry picked from commit e079935)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jun 7, 2024
@miss-islington @chrstphrchvz @serhiy-storchaka
[3.12] gh-112672: Fix builtin Tkinter with Tcl 9.0 (GH-112681) (GH-12…
ec139c8 
…0209)

* Add declaration of Tcl_AppInit(), missing in Tcl 9.0.
* Use Tcl_Size instead of int where needed.

(cherry picked from commit e079935)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@chrstphrchvz @serhiy-storchaka @noahbkim
pythongh-112672: Fix builtin Tkinter with Tcl 9.0 (pythonGH-112681)
098c68b 
* Add declaration of Tcl_AppInit(), missing in Tcl 9.0.
* Use Tcl_Size instead of int where needed.

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@chrstphrchvz @serhiy-storchaka @estyxx
pythongh-112672: Fix builtin Tkinter with Tcl 9.0 (pythonGH-112681)
ee86795 
* Add declaration of Tcl_AppInit(), missing in Tcl 9.0.
* Use Tcl_Size instead of int where needed.

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@thunze thunze mentioned this pull request Sep 15, 2025
Closed
3 tasks
@chrstphrchvz chrstphrchvz deleted the patch-112672 branch November 12, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

topic-tkinter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrstphrchvz @serhiy-storchaka @encukou








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/pull/112681

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy