Content-Length: 437550 | pFad | https://github.com/python/cpython/pull/119209

9B gh-119180: PEP 649: Add __annotate__ attributes by JelleZijlstra · Pull Request #119209 · python/cpython · GitHub
Skip to content

gh-119180: PEP 649: Add __annotate__ attributes#119209

Merged
ambv merged 11 commits intopython:mainfrom
JelleZijlstra:pep649-anno
May 22, 2024
Merged

gh-119180: PEP 649: Add __annotate__ attributes#119209
ambv merged 11 commits intopython:mainfrom
JelleZijlstra:pep649-anno

Conversation

@JelleZijlstra
Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra commented May 20, 2024 •
edited by bedevere-app bot
Loading

This implements https://peps.python.org/pep-0649/#annotate-and-annotations. In separate PRs I will work on making the compiler synthesize __annotate__ functions.

@JelleZijlstra JelleZijlstra changed the title PEP 649: Add __annotate__ attributes gh-119180: PEP 649: Add __annotate__ attributes May 20, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 20, 2024
Closed
30 tasks
@JelleZijlstra JelleZijlstra requested a review from ambv May 20, 2024 15:41
@AlexWaygood AlexWaygood removed their request for review May 20, 2024 21:24
picnixz
picnixz reviewed May 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. I'm wondering whether the error message "annotate returned a non-dict" could be changed to "annotate must return a dict" or "did not return a dict"

@JelleZijlstra
Copy link
Copy Markdown
Member Author

JelleZijlstra commented May 21, 2024

Some comments. I'm wondering whether the error message "annotate returned a non-dict" could be changed to "annotate must return a dict" or "did not return a dict"

For comparison:

>>> iter(X())
Traceback (most recent call last):
  File "<python-input-4>", line 1, in <module>
    iter(X())
    ~~~~^^^^^
TypeError: iter() returned non-iterator of type 'int'

I think I'll make the __annotate__ errors similar.

carljm
carljm reviewed May 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, a few comments.

I would prefer to remove the "set __annotate__ to None" behavior; I guess we would have to ask the Steering Council about that. Maybe not worth it unless we see it causing confusion in practice.

@JelleZijlstra JelleZijlstra mentioned this pull request May 21, 2024
Merged
@ambv ambv merged commit e9875ec into python:main May 22, 2024
@JelleZijlstra JelleZijlstra deleted the pep649-anno branch May 22, 2024 06:47
@JelleZijlstra JelleZijlstra mentioned this pull request May 29, 2024
Closed
9 tasks
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@JelleZijlstra @estyxx
pythongh-119180: PEP 649: Add __annotate__ attributes (python#119209)
577d2a5
@JelleZijlstra JelleZijlstra restored the pep649-anno branch September 10, 2024 23:37
@Zheaoli Zheaoli mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm left review comments

@picnixz picnixz picnixz left review comments

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@ambv ambv Awaiting requested review from ambv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JelleZijlstra @carljm @picnixz @ambv








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/pull/119209

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy