GH-123545: Remove duplicative Py_DECREF when handling _PyOptimizer_Optimize errors#123546
Conversation
brandtbucher
left a comment
brandtbucher
left a comment
There was a problem hiding this comment.
Yep, it looks like this is taken care of in error_tier_two (where GOTO_UNWIND() jumps). Just one suggestion for rewording the NEWS entry:
|
This will probably require a manual backport, unfortunately. |
brandtbucher
added
type-bug
|
Also, the test failures are weird, but look unrelated. |
They are unrelated. They are caused by some weird glibc stuff so don't worry! |
brandtbucher
left a comment
brandtbucher
left a comment
There was a problem hiding this comment.
Awesome, thanks!
The automatic backport will probably fail, but the bot should give you instructions for how to do it manually. Let me know if you need help. I think only _DYNAMIC_EXIT needs to be updated for 3.13, since _EXIT_TRACE works differently on that branch.
|
Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @savannahostrowski and @brandtbucher, I could not cleanly backport this to |
…ptimizer_Optimize errors (pythonGH-123546) (cherry picked from commit 1fbc118) Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com>
|
GH-123759 is a backport of this pull request to the 3.13 branch. |
|
GH-123759 is a backport of this pull request to the 3.13 branch. |
3 participants
This PR removes duplicative
Py_DECREFcalls when_PyOptimizer_Optimizereturns-1. In both cases, we do so in the conditional block and then as part of theGOTO_UNWINDmacro. This never really happens in practice, but it would be problematic if this error'd.Py_DECREFwhen handling_PyOptimizer_Optimizeerrors #123545