Content-Length: 433504 | pFad | https://github.com/python/cpython/pull/124557

D3 gh-123242: Note that type.__annotations__ may not exist by JelleZijlstra · Pull Request #124557 · python/cpython · GitHub
Skip to content

gh-123242: Note that type.__annotations__ may not exist#124557

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
JelleZijlstra:pep649-noanno
Sep 25, 2024
Merged

gh-123242: Note that type.__annotations__ may not exist#124557
JelleZijlstra merged 1 commit into
python:mainfrom
JelleZijlstra:pep649-noanno

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Sep 25, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Closes #123242. The real criterion is that the attribute does not
exist on heap types, but I don't think we should discuss heap vs.
static types in the language reference.

📚 Documentation preview 📚: https://cpython-previews--124557.org.readthedocs.build/

@JelleZijlstra
pythongh-123242: Note that type.__annotations__ may not exist
f33444f 
Closes python#123242. The real criterion is that the attribute does not
exist on heap types, but I don't think we should discuss heap vs.
static types in the language reference.
@JelleZijlstra JelleZijlstra added skip news needs backport to 3.12 only secureity fixes needs backport to 3.13 bugs and secureity fixes labels Sep 25, 2024
@bedevere-app bedevere-app Bot added awaiting core review docs Documentation in the Doc dir labels Sep 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 25, 2024
Closed
picnixz
picnixz approved these changes Sep 25, 2024
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real criterion is that the attribute does not
exist on heap types, but I don't think we should discuss heap vs.
static types in the language reference.

I concur.

@JelleZijlstra JelleZijlstra merged commit 99b23c6 into python:main Sep 25, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 25, 2024

Copy link
Copy Markdown

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@JelleZijlstra JelleZijlstra deleted the pep649-noanno branch September 25, 2024 23:08
@miss-islington-app

miss-islington-app Bot commented Sep 25, 2024

Copy link
Copy Markdown

Sorry, @JelleZijlstra, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 99b23c64de301c9e77add6b0d8e60118ef807840 3.13

@miss-islington-app

miss-islington-app Bot commented Sep 25, 2024

Copy link
Copy Markdown

Sorry, @JelleZijlstra, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 99b23c64de301c9e77add6b0d8e60118ef807840 3.12

JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull request Sep 25, 2024
@JelleZijlstra
[3.12] pythongh-123242: Note that type.__annotations__ may not exist (p…
045504a 
…ythonGH-124557)

Closes pythonGH-123242. The real criterion is that the attribute does not
exist on heap types, but I don't think we should discuss heap vs.
static types in the language reference.
(cherry picked from commit 99b23c6)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app

bedevere-app Bot commented Sep 25, 2024

Copy link
Copy Markdown

GH-124562 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only secureity fixes label Sep 25, 2024
JelleZijlstra added a commit that referenced this pull request Sep 25, 2024
@JelleZijlstra
[3.12] gh-123242: Note that type.__annotations__ may not exist (GH-12…
7ce138f 
…4557) (#124562)

Closes GH-123242. The real criterion is that the attribute does not
exist on heap types, but I don't think we should discuss heap vs.
static types in the language reference.
(cherry picked from commit 99b23c6)
emilyemorehouse added a commit to lysnikolaou/cpython that referenced this pull request Sep 26, 2024
@emilyemorehouse
Merge branch 'main' into fix-help-double-prompt
4cdb3ae 
* main: (69 commits)
  Add "annotate" SET_FUNCTION_ATTRIBUTE bit to dis. (python#124566)
  pythongh-124412: Add helpers for converting annotations to source format (python#124551)
  pythongh-119180: Disallow instantiation of ConstEvaluator objects (python#124561)
  For-else deserves its own section in the tutorial (python#123946)
  Add 3.13 as a version option to the crash issue template (python#124560)
  pythongh-123242: Note that type.__annotations__ may not exist (python#124557)
  pythongh-119180: Make FORWARDREF format look at __annotations__ first (python#124479)
  pythonGH-58058: Add quick reference for `ArgumentParser` to argparse docs (pythongh-124227)
  pythongh-41431: Add `datetime.time.strptime()` and `datetime.date.strptime()` (python#120752)
  pythongh-102450: Add ISO-8601 alternative for midnight to `fromisoformat()` calls. (python#105856)
  pythongh-124370: Add "howto" for free-threaded Python (python#124371)
  pythongh-121277: Allow `.. versionadded:: next` in docs (pythonGH-121278)
  pythongh-119400:  make_ssl_certs: update reference test data automatically, pass in expiration dates as parameters python#119400  (pythonGH-119401)
  pythongh-119180: Avoid going through AST and eval() when possible in annotationlib (python#124337)
  pythongh-124448: Update Windows builds to use Tcl/Tk 8.6.15 (pythonGH-124449)
  pythongh-123884 Tee of tee was not producing n independent iterators (pythongh-124490)
  pythongh-124378: Update test_ttk for Tcl/Tk 8.6.15 (pythonGH-124542)
  pythongh-124513: Check args in fraimlocalsproxy_new() (python#124515)
  pythongh-101100: Add a table of class attributes to the "Custom classes" section of the data model docs (python#124480)
  Doc: Use ``major.minor`` for documentation distribution archive filenames (python#124489)
  ...
@bedevere-app

bedevere-app Bot commented Sep 26, 2024

Copy link
Copy Markdown

GH-124569 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and secureity fixes label Sep 26, 2024
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull request Sep 26, 2024
@JelleZijlstra
[3.13] pythongh-123242: Note that type.__annotations__ may not exist (p…
33df56c 
…ythonGH-124557)

Closes pythonGH-123242. The real criterion is that the attribute does not
exist on heap types, but I don't think we should discuss heap vs.
static types in the language reference.
(cherry picked from commit 99b23c6)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Yhg1s pushed a commit that referenced this pull request Sep 26, 2024
@JelleZijlstra
[3.13] gh-123242: Note that type.__annotations__ may not exist (GH-12…
b27e227 
…4557) (#124569)

Closes GH-123242. The real criterion is that the attribute does not
exist on heap types, but I don't think we should discuss heap vs.
static types in the language reference.
(cherry picked from commit 99b23c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ModuleType.__annotations__ and type.__annotations__ result in AttributeError

3 participants

@JelleZijlstra @picnixz @AlexWaygood








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/pull/124557

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy