GH-125069: Fix inconsistent joining in WindowsPath(PosixPath(...))#125156
Merged
barneygale merged 6 commits intopython:mainfrom Oct 13, 2024
Merged
GH-125069: Fix inconsistent joining in WindowsPath(PosixPath(...))#125156barneygale merged 6 commits intopython:mainfrom
WindowsPath(PosixPath(...))#125156barneygale merged 6 commits intopython:mainfrom
Conversation
…..))` `PurePath.__init__()` incorrectly uses the `_raw_paths` of a given `PurePath` object with a different flavour, even though the procedure to join path segments can differ between flavours. This change makes the `_raw_paths`-enabled deferred joining apply _only_ when the path flavours match.
barneygale
added
topic-pathlib
needs backport to 3.12
rruuaanng
reviewed
Oct 9, 2024
picnixz
reviewed
Oct 11, 2024
…RP0Mx.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Contributor
Author
|
Some background info: the str(Path('a') / 'b' / 'c' / 'd' / 'e')Without deferred joining, this requires four calls to
With deferred joining, it calls |
picnixz
reviewed
Oct 13, 2024
Contributor
Author
|
Thank you very much for the review, @picnixz |
Member
|
Always happy to review them! |
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 13, 2024
…..))` (pythonGH-125156) `PurePath.__init__()` incorrectly uses the `_raw_paths` of a given `PurePath` object with a different flavour, even though the procedure to join path segments can differ between flavours. This change makes the `_raw_paths`-enabled deferred joining apply _only_ when the path flavours match. (cherry picked from commit cb8e599) Co-authored-by: Barney Gale <barney.gale@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
Sorry, @barneygale, I could not cleanly backport this to |
|
GH-125409 is a backport of this pull request to the 3.13 branch. |
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
Oct 13, 2024
…xPath(...))` (pythonGH-125156) `PurePath.__init__()` incorrectly uses the `_raw_paths` of a given `PurePath` object with a different flavour, even though the procedure to join path segments can differ between flavours. This change makes the `_raw_paths`-enabled deferred joining apply _only_ when the path flavours match. Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>. (cherry picked from commit cb8e599) Co-authored-by: Barney Gale <barney.gale@gmail.com>
|
GH-125410 is a backport of this pull request to the 3.12 branch. |
barneygale
added a commit
that referenced
this pull request
Oct 13, 2024
…...))` (GH-125156) (#125409) `PurePath.__init__()` incorrectly uses the `_raw_paths` of a given `PurePath` object with a different flavour, even though the procedure to join path segments can differ between flavours. This change makes the `_raw_paths`-enabled deferred joining apply _only_ when the path flavours match. (cherry picked from commit cb8e599) Co-authored-by: Barney Gale <barney.gale@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
barneygale
added a commit
that referenced
this pull request
Oct 13, 2024
…...))` (GH-125156) (#125410) `PurePath.__init__()` incorrectly uses the `_raw_paths` of a given `PurePath` object with a different flavour, even though the procedure to join path segments can differ between flavours. This change makes the `_raw_paths`-enabled deferred joining apply _only_ when the path flavours match. (cherry picked from commit cb8e599) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PurePath.__init__()incorrectly uses the_raw_pathsof a givenPurePathobject with a different flavour, even though the procedure to join path segments can differ between flavours.This change makes the
_raw_paths-enabled deferred joining apply only when the path flavours match.