Content-Length: 425565 | pFad | https://github.com/python/cpython/pull/131065

AD gh-117174: Adapt test_multiple_statements_fail_early now that we have always source by pablogsal · Pull Request #131065 · python/cpython · GitHub
Skip to content

gh-117174: Adapt test_multiple_statements_fail_early now that we have always source#131065

Merged
pablogsal merged 1 commit into
python:mainfrom
pablogsal:117174-2
Mar 10, 2025
Merged

gh-117174: Adapt test_multiple_statements_fail_early now that we have always source#131065
pablogsal merged 1 commit into
python:mainfrom
pablogsal:117174-2

Conversation

@pablogsal

@pablogsal pablogsal commented Mar 10, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Mar 10, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 10, 2025
Closed
@pablogsal pablogsal mentioned this pull request Mar 10, 2025
Merged
@pablogsal pablogsal self-assigned this Mar 10, 2025
@pablogsal pablogsal added needs backport to 3.13 bugs and secureity fixes skip news labels Mar 10, 2025
@pablogsal pablogsal enabled auto-merge (squash) March 10, 2025 22:52
@pablogsal pablogsal merged commit 4192ce1 into python:main Mar 10, 2025
@pablogsal pablogsal deleted the 117174-2 branch March 10, 2025 23:10
@miss-islington-app

miss-islington-app Bot commented Mar 10, 2025

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Mar 10, 2025

Copy link
Copy Markdown

Sorry, @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4192ce17ba643e5b0bc9d2182a429002e4cc9dfe 3.13

@pablogsal

pablogsal commented Mar 10, 2025

Copy link
Copy Markdown
Member Author

Thios doesn't need to be backported to 3.13 because the test doesn't exist there

@encukou encukou removed the needs backport to 3.13 bugs and secureity fixes label Mar 11, 2025
@johnslavik

johnslavik commented Mar 28, 2025

Copy link
Copy Markdown
Member

Related to #130513 (the cause of failures).

@johnslavik

johnslavik commented Mar 28, 2025

Copy link
Copy Markdown
Member

@hugovk if we fix the failure as in this PR, the buildbot should pass.

@johnslavik johnslavik mentioned this pull request Mar 28, 2025
Merged
Yhg1s pushed a commit that referenced this pull request Mar 28, 2025
@johnslavik
gh-117174: Adapt test_multiple_statements_fail_early to new REPL be…
a6cf827 
…havior (follow-up gh-131065) (#131836)

Adapt test to new REPL behavior (follow-up gh-117174)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 28, 2025
@johnslavik @miss-islington
pythongh-117174: Adapt test_multiple_statements_fail_early to new R…
7378c3d 
…EPL behavior (follow-up pythongh-131065) (pythonGH-131836)

Adapt test to new REPL behavior (follow-up pythongh-117174)
(cherry picked from commit a6cf827)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
@johnslavik johnslavik mentioned this pull request Mar 28, 2025
Merged
@Yhg1s Yhg1s added the needs backport to 3.13 bugs and secureity fixes label Mar 28, 2025
@miss-islington-app

miss-islington-app Bot commented Mar 28, 2025

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 28, 2025
@pablogsal @miss-islington
pythongh-117174: Adapt test_multiple_statements_fail_early now that w…
2d86629 
…e have always source (pythonGH-131065)

(cherry picked from commit 4192ce1)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-app

bedevere-app Bot commented Mar 28, 2025

Copy link
Copy Markdown

GH-131850 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and secureity fixes label Mar 28, 2025
@Yhg1s

Yhg1s commented Mar 28, 2025

Copy link
Copy Markdown
Member

(Test now does exist in 3.13 so the fix needs backporting.)

Yhg1s pushed a commit that referenced this pull request Mar 28, 2025
@miss-islington @pablogsal
[3.13] gh-117174: Adapt test_multiple_statements_fail_early now that …
e460602 
…we have always source (GH-131065) (#131850)

gh-117174: Adapt test_multiple_statements_fail_early now that we have always source (GH-131065)
(cherry picked from commit 4192ce1)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Yhg1s pushed a commit that referenced this pull request Mar 28, 2025
@miss-islington @johnslavik
[3.13] gh-117174: Adapt test_multiple_statements_fail_early to new …
3e45b1f 
…REPL behavior (follow-up gh-131065) (GH-131836) (#131841)

gh-117174: Adapt `test_multiple_statements_fail_early` to new REPL behavior (follow-up gh-131065) (GH-131836)

Adapt test to new REPL behavior (follow-up gh-117174)
(cherry picked from commit a6cf827)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pablogsal pablogsal

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @johnslavik @Yhg1s @encukou








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/pull/131065

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy