gh-132983: Remove pyzstd in identifiers#133535
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Thanks @emmatyping for the explanation about the context, pinging you for review as suggested 🤗 |
emmatyping
left a comment
emmatyping
left a comment
There was a problem hiding this comment.
Looks good! Just want to make sure we make these static since they are local to their translation unit (file).
emmatyping
left a comment
emmatyping
left a comment
There was a problem hiding this comment.
Test failure looks unrelated. Thanks for the PR!
|
Note: in general we don't need to update the branch, it wastes CI resources. I tend to do so only sparingly. |
|
Thanks @Rogdham for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
(cherry picked from commit 2cc6de7) Co-authored-by: Rogdham <3994389+Rogdham@users.noreply.github.com>
|
GH-133629 is a backport of this pull request to the 3.14 branch. |
I only did so to sort out CI failures which would block merge. |
|
Sorry! I missed that, thanks. |
3 participants
The
_PyZstd_xxxextern functions were leftover artifacts of the move from pyzstd to cpython.I have renamed them to the
_zstd_xxxconvention used for private functions.