gh-132983: Convert zstd __new__ methods to Argument Clinic#133860
Merged
Conversation
AA-Turner
changed the title
13 tasks
emmatyping
reviewed
May 12, 2025
emmatyping
reviewed
May 12, 2025
emmatyping
approved these changes
May 12, 2025
emmatyping
left a comment
emmatyping
left a comment
Member
There was a problem hiding this comment.
A few suggestions but otherwise looks great!
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 12, 2025
…ythonGH-133860) (cherry picked from commit d29ddbd) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
GH-133915 is a backport of this pull request to the 3.14 branch. |
Member
|
Since this was merged, buildbots started showing reference leaks, e.g. here. |
Member
|
See #133962 for a fix-up. |
AA-Turner
added a commit
that referenced
this pull request
May 20, 2025
…GH-133860) (#133915) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tp_initfunctions intotp_newand convert the latter to AC. This also means we can remove theinitialisedmember from the object structs.ZstdDictto make the content positional-only andis_rawkw-only.A
cc @Rogdham